search

JuliaReach / Reachability.jl

Reachability and Safety of Nondeterministic Dynamical Systems
MIT License
50 stars 4 forks source link

Add checking property for flowpipes with mixed dimensions #660

Closed kpotomkin closed 5 years ago

kpotomkin commented 5 years ago

Thanks for the contribution. Can you add a test that covers the new functionality? This could be re-using some of the existing models and just changing algorithm-specific options.

As far as I know we don't have a check for hybrid systems at all. I can consider thermostat model and a bad state x<=18, does it work for you?

mforets commented 5 years ago

As far as I know we don't have a check for hybrid systems at all.

Yes we do; i mean check in the sense of running the new code in some problem(s). I recall that doing this kind of "check" uncovered 2 distinct problems in BFFPS. This is the baseline check of course (test that the code actually works in the examples of the test folder). If you also have @test for some of the new funcionality that is also welcome!

schillic commented 5 years ago

Yes we do

What @kostakoida means is "property checking for hybrid models," and indeed we do not test this at the moment. I think the property suggested is fine and it should be easy to add that (if not, let me know).