JuliaReach / Reachability.jl

Reachability and Safety of Nondeterministic Dynamical Systems
MIT License
50 stars 4 forks source link

Inconsistent behavior of GLGM06 across (in)homogeneous cases #680

Closed schillic closed 4 years ago

schillic commented 4 years ago

In the homogeneous case, we use an algorithm with wrapping effect: https://github.com/JuliaReach/Reachability.jl/blob/29f5a2ce7842c5678a6cf88954924aacffeaa7fe/src/ReachSets/ContinuousPost/GLGM06/reach.jl#L19

In the inhomogeneous case, we use an algorithm without wrapping effect (except in the inputs): https://github.com/JuliaReach/Reachability.jl/blob/29f5a2ce7842c5678a6cf88954924aacffeaa7fe/src/ReachSets/ContinuousPost/GLGM06/reach.jl#L51

mforets commented 4 years ago

In the homogeneous case, we use an algorithm with wrapping effect:

in this scenario, the linear map is exact, so i don't expect to see a difference between recursive and not. in fact the call to reduce_order in the following line is not needed.

mforets commented 4 years ago

do reopen if you disagree :)