JuliaReach / Reachability.jl

Reachability and Safety of Nondeterministic Dynamical Systems
MIT License
50 stars 4 forks source link

Solve stops before time horizon in TMJets #700

Closed mforets closed 4 years ago

mforets commented 4 years ago

The solution of a nonlinear system with TMJets stops the simulation before the time horizon in some cases. For instance, in the Lorenz model,

sol.Xk[end].t_end

0.09422875648577093
mforets commented 4 years ago

Actually, the problem is that by default we don't print the info, which is in this line. Hence, in the model referenced above we were just not using enough maximum steps.

So i would suggest that we wither change that line with an error, or return the computed flowpipe until max_steps but always print a message.

Thanks @lbenet for helping me to understand this.

mforets commented 4 years ago

I will go for using the warning level message, because this is shown by default, and one still recovers the computed flowpipe prior to stopping, which seems useful to have.

lbenet commented 4 years ago

I will go for using the warning level message, because this is shown by default, and one still recovers the computed flowpipe prior to stopping, which seems useful to have.

Thanks for reporting. I agree that it might be better to have some sort of warning/info message, and then return the so-far obtained solution. I'll take care of this.

mforets commented 4 years ago

No problem, note that a fix is proposed in mforets/700. For reasons discussed elsewhere, this package has its own copy of validated integ.