search

JuliaReach / Reachability.jl

Reachability and Safety of Nondeterministic Dynamical Systems
MIT License
50 stars 4 forks source link

Revise order reduction in GLGM06 #751

Closed schillic closed 4 years ago

schillic commented 4 years ago

Originally this PR should just remove the order reduction in a homogeneous GLGM06 run.

~But then I hit a wall that the new LazySets v1.32 is incompatible with our flowpipes consisting of sets of fixed type (because the type may change during the analysis).~

~This PR adds a brute-force conversion for GLGM06 but some work would be needed for other algorithms as well.~ ~(The conversion after order reduction might be redundant.)~

mforets commented 4 years ago

this PR still applies or it was superseded by a more recent one?

schillic commented 4 years ago

I rethought this and actually there is no need to change the behavior. In the homogeneous case it still makes sense to reduce the order of Ω0 to deal with cheaper zonotopes. So I was about to propose that we do not merge this PR. But then I realized that the behavior is inconsistent: in the homogeneous we reduce the order of Ω0 but in the inhomogeneous case we do not. So I refactored that part.