search

JuliaReach / SpaceExParser.jl

Parser for the SpaceEx modeling language in Julia
https://juliareach.github.io/SpaceExParser.jl/
MIT License
7 stars 1 forks source link

Error in filtered_oscillator_16 and 32 #2

Closed mforets closed 6 years ago

mforets commented 6 years ago 
$ sspaceex -g filtered_oscillator_16.cfg -m filtered_oscillator_16.xml -o out --output-system-file filtered_oscillator_16_flattened.xml

ERROR: Failed to parse model file filtered_oscillator_16.xml.
caused by: Could not parse network component osc_w_16th_order.
caused by: Could not parse network component osc_w_16th_order.f8a.
caused by: Cannot map controlled parameter x to uncontrolled parameter osc_w_16th_order.x1.
$ sspaceex -g filtered_oscillator_32.cfg -m filtered_oscillator_32.xml -o out --output-system-file filtered_oscillator_32_flattened.xml

ERROR: Failed to parse model file filtered_oscillator_32.xml.
caused by: Could not parse network component osc_w_32th_order.
caused by: Could not parse network component osc_w_32th_order.f8d.
caused by: Cannot map controlled parameter x to uncontrolled parameter osc_w_32th_order.z.
nikos-kekatos commented 6 years ago

I think that there are errors in all of them.

nikos-kekatos commented 6 years ago

One thing is with the special symbols used in the notes and another one is with variable names (MOE does not support component_name.variable_name notation, although SpaceEx executable can handle it)

mforets commented 6 years ago

I think that there are errors in all of them.

Alright. Feel free to make a PR with other hybrid models that you may want to try. We have several others in the reachability benchmarks repo, but these are purely continuous.

nikos-kekatos commented 6 years ago

Yes yes, I will do that. For now, we need to check all the flattened models and probably document what are some common errors. It might be necessary to have a postprocessing step so as to be certain that the constructed model works fine..