search

JuliaRegistries / CompatHelper.jl

Automatically update the [compat] entries for your Julia package's dependencies
https://JuliaRegistries.github.io/CompatHelper.jl/dev/
MIT License
138 stars 39 forks source link

NewVersions utility functions #339

Closed mattBrzezinski closed 3 years ago

mattBrzezinski commented 3 years ago

I was originally going to re-write the new_versions.jl file, but realized there are too many smaller functions and it would become an eye-sore to read through.

Instead, here's a smaller PR for some utility functions that will be used in a future PR.

mattBrzezinski commented 3 years ago

bors try

bors[bot] commented 3 years ago

try

Build succeeded:

mattBrzezinski commented 3 years ago

bors try

DilumAluthge commented 3 years ago

version_verbatim should be compat_entry_verbatim instead?

mattBrzezinski commented 3 years ago

version_verbatim should be compat_entry_verbatim instead?

As a param name?

DilumAluthge commented 3 years ago

Yeah. Since that variable refers to [compat] entry strings, right?

Otherwise LGTM.

mattBrzezinski commented 3 years ago

bors r+

mattBrzezinski commented 3 years ago

bors r+

mattBrzezinski commented 3 years ago

Bors is down?

DilumAluthge commented 3 years ago

Yeah, looks like it.

mattBrzezinski commented 3 years ago

bors r+

bors[bot] commented 3 years ago

Build succeeded: