Exclude yanked versions by default (but allow users to include yanked versions by setting `include_yanked = true`)

JuliaRegistries / CompatHelper.jl

Automatically update the [compat] entries for your Julia package's dependencies

https://JuliaRegistries.github.io/CompatHelper.jl/dev/

MIT License

138 stars 40 forks source link

Exclude yanked versions by default (but allow users to include yanked versions by setting `include_yanked = true`) #418

Closed DilumAluthge closed 2 years ago

DilumAluthge commented 2 years ago

@mattBrzezinski @fchorney Which do you prefer for the public API?

include_yanked with a default of false
exclude_yanked with a default of true

fchorney commented 2 years ago

include_yanked with a default of false

exclude_yanked with a default of true

I guess 1 possibly makes more sense, but I honestly have a hard time deciding if one is better than the other.

DilumAluthge commented 2 years ago

bors merge

DilumAluthge commented 2 years ago

@mattBrzezinski @fchorney Similar to #419, I'm going to merge this now so that we can get 3.2.0 registered by 00:00 UTC, but feel free to continue reviewing post-merge.

bors[bot] commented 2 years ago

Build succeeded: