search

JuliaRegistries / CompatHelper.jl

Automatically update the [compat] entries for your Julia package's dependencies
https://JuliaRegistries.github.io/CompatHelper.jl/dev/
MIT License
138 stars 40 forks source link

Adds changes to fix GitForge compat bump #440

Closed BaileyBox closed 2 years ago

BaileyBox commented 2 years ago

Skipping 0.3 and going to 0.4 to (hopefully) fix the datetime changes between 0.3 and 0.4.1 found here.

Edit: After running bors, all the tests pass. Should be good to merge.

BaileyBox commented 2 years ago

bors try

bors[bot] commented 2 years ago

try

Build succeeded:

DilumAluthge commented 2 years ago

Do we actually support 0.3? I thought our tests were broken on GitForge 0.3.

mattBrzezinski commented 2 years ago

Do we actually support 0.3? I thought our tests were broken on GitForge 0.3.

Do we actually support 0.3? I thought our tests were broken on GitForge 0.3.

I'm not seeing any issues for GitForge, should test specifically against 0.3 though to be sure.

BaileyBox commented 2 years ago

Do we actually support 0.3? I thought our tests were broken on GitForge 0.3.

Do we actually support 0.3? I thought our tests were broken on GitForge 0.3.

I'm not seeing any issues for GitForge, should test specifically against 0.3 though to be sure.

The issue we were having was a failing Integration test when bors was run. It was giving us a DateFormat issue.

Additionally, with the change to one of the tests adding GitForge.ForgeAPINotImplemented instead of ExceptionError being thrown, I don't think this will support 0.3 (ForgeAPINotImplemented not added until v0.4.0)

mattBrzezinski commented 2 years ago

Do we actually support 0.3? I thought our tests were broken on GitForge 0.3.

Do we actually support 0.3? I thought our tests were broken on GitForge 0.3.

I'm not seeing any issues for GitForge, should test specifically against 0.3 though to be sure.

The issue we were having was a failing Integration test when bors was run. It was giving us a DateFormat issue.

Additionally, with the change to one of the tests adding GitForge.ForgeAPINotImplemented instead of ExceptionError being thrown, I don't think this will support 0.3 (ForgeAPINotImplemented not added until v0.4.0)

Ah I see, yeah I'd say just drop 0.3, idk if people have thoughts on dropping 0.2 too?

DilumAluthge commented 2 years ago

I'm fine with dropping everything before 0.4.

BaileyBox commented 2 years ago

Should be good to merge now :)

BaileyBox commented 2 years ago

bors merge

bors[bot] commented 2 years ago

Build succeeded: