search

JuliaRegistries / Registrator.jl

Julia package registration bot
https://julialang.org/packages
Other
210 stars 47 forks source link

The `Project.toml` and `Manifest.toml` files are out of sync #389

Closed DilumAluthge closed 2 years ago

DilumAluthge commented 2 years ago

The Project.toml file has this [compat] entry:

https://github.com/JuliaRegistries/Registrator.jl/blob/30b948e52271b4644c2fc6c4afcda6325c472082/Project.toml#L32-L32

However, the Manifest.toml file has GitForge 0.1.7:

https://github.com/JuliaRegistries/Registrator.jl/blob/30b948e52271b4644c2fc6c4afcda6325c472082/Manifest.toml#L70-L74

In other words, the Manifest.toml file is not a valid resolve of the Project.toml file. This happened because in https://github.com/JuliaRegistries/Registrator.jl/commit/0d1a041d977bc4ba953fd7a173576f5c92167740, the Project.toml file was edited, but the Manifest.toml file was not re-resolved. This will be fixed by re-resolving the manifest (https://github.com/JuliaRegistries/Registrator.jl/pull/388).

We didn't catch this issue because we don't currently have CI on this repository. In #387, I add a CI job that, among other things, tests that the Manifest.toml file that has been checked into source control is a valid resolve of the Project.toml file. So in the future we will catch this kind of issue before the PR is merged.