JuliaRegistries / Registrator.jl

Julia package registration bot
https://julialang.org/packages
Other
210 stars 47 forks source link

make Registrator work with the new breaking version of RegistryTools #397

Closed KristofferC closed 1 year ago

KristofferC commented 1 year ago

See https://github.com/JuliaRegistries/RegistryTools.jl/pull/78 for rationale

nkottary commented 1 year ago

I get this error when trying webui out:

┌ Error: handle_connection handler error
│   exception = (ErrorException("type Dict has no field name"), Base.StackTraces.StackFrame[register(r::HTTP.Messages.Request) at register.jl:49, 
nkottary commented 1 year ago

This constructor needs to be defined:

┌ Info: Unexpected error: MethodError: no method matching Registrator.RegisterParams(::String, ::RegistryTools.Project, ::String; subdir="", registry="https://nkottary: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@gith
ub.com/registratortestorg/TestRegistry", registry_fork="https://nkottary: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@github.com/registratortestorg/TestRegistry", registry_deps=["https://github.com/JuliaRegistries/Gen
eral"], push=true)
│ Closest candidates are:
│   Registrator.RegisterParams(::String, ::RegistryTools.Project, ::String, !Matched::String, !Matched::String, !Matched::Vector{<:String}, !Matched::String, !Matched::Bool, !Matched::Dict) at ~/Registrator.jl/src
/Registrator.jl:13 got unsupported keyword arguments "subdir", "registry", "registry_fork", "registry_deps", "push"
│   Registrator.RegisterParams(::Any, ::Any, ::Any, !Matched::Any, !Matched::Any, !Matched::Any, !Matched::Any, !Matched::Any, !Matched::Any) at ~/Registrator.jl/src/Registrator.jl:13 got unsupported keyword argum
ents "subdir", "registry", "registry_fork", "registry_deps", "push"
│ Stacktrace:
│  [1] action(rp::Registrator.CommentBot.RequestParams{Registrator.CommentBot.CommitCommentTrigger}, zsock::Registrator.Messaging.RequestSocket)
│    @ Registrator.CommentBot ~/Registrator.jl/src/commentbot/CommentBot.jl:152
KristofferC commented 1 year ago

Should be fixed