JuliaRegistries / RegistryCI.jl

Continuous integration (CI) tools for Julia package registries, including registry consistency testing, automatic merging (automerge) of pull requests, and automatic TagBot triggers
https://juliaregistries.github.io/RegistryCI.jl/stable
Other
31 stars 30 forks source link

🤖 Automatically format the source code files #416

Closed github-actions[bot] closed 3 years ago

github-actions[bot] commented 3 years ago

This pull request formats the source code files using the JuliaFormatter package.

DilumAluthge commented 3 years ago

bors merge

bors[bot] commented 3 years ago

Build succeeded:

DilumAluthge commented 3 years ago

We could choose a different style? JuliaFormatter has its own default style, and also has YASGuide and BlueStyle. (These changes are BlueStyle.)

Alternatively, we could just disable the auto-formatter, and revert the formatting PRs (e.g. this PR), and call it a day.

GunnarFarneback commented 3 years ago

If everybody else loves it you should probably go with it, but I don't. (It's possible that some other style matches my preferences better but generally I've found that auto-formatting is always too rigid and gets in the way.)

ericphanson commented 3 years ago

I use YASGuide at work, so I am used to it and the quirks of autoformatting (which at least is better than trying to follow a style guide manually IMO). But I don't have a preference here, and don't mind not using a style guide at all, or choosing one of these. And I think if it really annoys Gunnar then we shouldn't do it 🙂 .