Revise the commit regex. #440

Closed GunnarFarneback closed 2 years ago

This revises the commit regex to match

r"Commit: ([0-9a-f]+)"

but no longer requires that it is a markdown item on a line of its own.

The rationale is https://github.com/GunnarFarneback/LocalRegistry.jl/pull/49, which makes use of "git push options" to create a pull request (only effective on GitLab). This provides a very low complexity pull request creation mechanism but has the limitation that it cannot pass newlines.

In terms of robustness and input sanitation this change makes no difference to Registrator generated pull requests.In fact it's rather stricter since the code in total only allows the commit hash to be exactly 40 hexadecimal digits.

Sounds fine to me, but the docs need to be updated too: https://juliaregistries.github.io/RegistryCI.jl/stable/regexes/

Yeah, the doctests are complaining.

Documentation builds fine now. The Julia nightly failure is unrelated.

@GunnarFarneback or @ericphanson Can one of you do the following:

Bump the minor version number (since this probably falls under new feature) so that we can register as soon as we merge.
Squash all commits into one (since Bors can't do a squash-merge).

Once the two above are done, @ericphanson please bors merge if this looks good to you.

bors merge

Build succeeded:

JuliaRegistries / RegistryCI.jl

Revise the commit regex. #440