search

JuliaRegistries / RegistryCI.jl

Continuous integration (CI) tools for Julia package registries, including registry consistency testing, automatic merging (automerge) of pull requests, and automatic TagBot triggers
https://juliaregistries.github.io/RegistryCI.jl/stable
Other
31 stars 30 forks source link

DelimitedFiles should now require compat entries #471

Open KristofferC opened 2 years ago

KristofferC commented 2 years ago

In https://github.com/JuliaRegistries/General/pull/66039, compat for DelimtiedFiles was added so that when people start using 1.9 (where DelimitedFiles is not an stdlib) the resolver should not start picking old versions without DelimitedFiles compat.

We should probably require packages to declare compat with DelimitedFIles to avoid this issue coming back. It is not super urgent though since we can always add new compat entries but would be good to get done.

The rule is basically that before 1.9 you need to have the same compat for DelimitedFiles as you do for Julia. After 1.9 you can have whatever you want.

ericphanson commented 2 years ago

IIRC Registrator hasn't been in the business of compat bounds, but rather RegistryCI. Moreover, I would prefer checks like this to go to the latter bc RegistryCI itself has CI (unlike Registrator) and the version deployed to General is public/readable unlike Registrator (which can make debugging hard/confusing), and there's a broader set of folks who can deploy RegistryCI (General committers vs only @nkottary AFAIK).

KristofferC commented 2 years ago

Yes, RegistratorCI is clearly where this should be opened. I moved it.

ericphanson commented 1 year ago

Taking another look at this:

  1. Guideline: https://github.com/JuliaRegistries/RegistryCI.jl/blob/0c50828db74921c7cd34b18da47ac0ddf9376a39/src/AutoMerge/guidelines.jl#L91
  2. Utils function: https://github.com/JuliaRegistries/RegistryCI.jl/blob/5f0aba4f6b95bfb63f03ab803f39721c2cd55baf/src/AutoMerge/util.jl#L232-L244
  3. General's workflow: https://github.com/JuliaRegistries/General/blob/a71c6fbf0766c12f54ea1cf23a3e7dc7277f380a/.github/workflows/automerge.yml#L22

It looks like once 1.9 is out, General's AutoMerge workflow will switch to 1.9, and presumably those Pkg internals will no longer have DelimitedFiles as a stdlib, so we will start requiring compat then.

Does that sound reasonable? Do we want to edit it so we rm DelimitedFiles from that list early so we start requiring it already?