search

JuliaRegistries / RegistryCI.jl

Continuous integration (CI) tools for Julia package registries, including registry consistency testing, automatic merging (automerge) of pull requests, and automatic TagBot triggers
https://juliaregistries.github.io/RegistryCI.jl/stable
Other
31 stars 30 forks source link

Pass guideline parameters in a dict #507

Open MarkNahabedian opened 1 year ago

MarkNahabedian commented 1 year ago

This change simplifies the passing of paramneters from the various Guidelines from run down to the various Guideline.checkfunctions.

Such parameters no longer need to be explicitly declared and passed through in various functions like pull_request_build.

The current passing of parameters for existing guidelines has not yet been changed. I could do that work in separate PRs if the package commiters encourage it.

This change was tested in the guideline_linecounts_meet_thresholds branch of my fork, which introduces a new guideline. The unit tests ran to completion. The unit test for the new guideline succeeded.

MarkNahabedian commented 1 year ago

Huh? Is there something I need to do?

I think this PR is awaiting review.

DilumAluthge commented 1 year ago

@ericphanson and/or @GunnarFarneback Can you review this?

MarkNahabedian commented 1 year ago

I despair of anyone ever reviewing this.