search

JuliaRegistries / RegistryCI.jl

Continuous integration (CI) tools for Julia package registries, including registry consistency testing, automatic merging (automerge) of pull requests, and automatic TagBot triggers
https://juliaregistries.github.io/RegistryCI.jl/stable
Other
31 stars 30 forks source link

Registry consistency tests: before doing certain equality comparisons, add whitespace before and after hyphens #514

Closed DilumAluthge closed 11 months ago

DilumAluthge commented 1 year ago

This is necessary due to https://github.com/JuliaLang/Pkg.jl/pull/3580, which made it onto Julia master in https://github.com/JuliaLang/julia/pull/51186.

giordano commented 1 year ago

Bump? Looking at CI marks in list of PRs in General is completely useless at the moment

DilumAluthge commented 1 year ago

Ah, I haven't had a chance to work on this. I might not get to it until next week.

@giordano If you want, you can take this PR over and work through the review comments.

giordano commented 1 year ago

Might be easier to just disable nightly on general st this point...

DilumAluthge commented 1 year ago

Might be easier to just disable nightly on general st this point...

Seems fine. We can re-enable after this PR is merged.

Can you make a PR?

DilumAluthge commented 11 months ago

I completely forgot about this PR, and now I need to get it in to fix CI so we can get https://github.com/JuliaRegistries/RegistryCI.jl/pull/516 merged and deployed.

I'll make a follow-up PR to address the review comments.

DilumAluthge commented 11 months ago

bors merge

bors[bot] commented 11 months ago

Build failed:

DilumAluthge commented 11 months ago

bors merge

bors[bot] commented 11 months ago

Build failed:

DilumAluthge commented 11 months ago

bors merge

bors[bot] commented 11 months ago

Build failed:

DilumAluthge commented 11 months ago

bors merge

bors[bot] commented 11 months ago

Build failed:

DilumAluthge commented 11 months ago

bors merge

bors[bot] commented 11 months ago

Build failed:

DilumAluthge commented 11 months ago

bors merge

bors[bot] commented 11 months ago

Build failed:

DilumAluthge commented 11 months ago

bors merge

bors[bot] commented 11 months ago

Build failed:

DilumAluthge commented 11 months ago

I'm going to need some way (such as https://github.com/JuliaLang/Pkg.jl/pull/3661) of disabling Pkg's precompilation workload in order to get the RegistryCI.jl unit tests to pass on Julia nightly.

DilumAluthge commented 11 months ago

bors merge

bors[bot] commented 11 months ago

Build failed:

DilumAluthge commented 11 months ago

bors merge

bors[bot] commented 11 months ago

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here. For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.