JuliaRegistries / RegistryCI.jl

Continuous integration (CI) tools for Julia package registries, including registry consistency testing, automatic merging (automerge) of pull requests, and automatic TagBot triggers
https://juliaregistries.github.io/RegistryCI.jl/stable
Other
31 stars 30 forks source link

Don't automerge packages whose names end with jl #555

Closed LilithHafner closed 7 months ago

LilithHafner commented 7 months ago

Inspired by https://github.com/JuliaRegistries/General/pull/100209. Whether or not folks decide to allow the name PsychoJL.jl, all such names should require manual approval.

DilumAluthge commented 7 months ago

Seems reasonable to me. Can you add a test?

ericphanson commented 7 months ago

BTW IMO we can test it with unit tests for meets_julia_name_check rather than full integration tests (which are more complicated)

ericphanson commented 7 months ago

merge queue will run integration tests, and if they pass it will merge. We could bump for a release now as well to get it deployed, but I was hoping to get some more PRs in before the next release