search

JuliaRegistries / RegistryCI.jl

Continuous integration (CI) tools for Julia package registries, including registry consistency testing, automatic merging (automerge) of pull requests, and automatic TagBot triggers
https://juliaregistries.github.io/RegistryCI.jl/stable
Other
31 stars 30 forks source link

Open tagbot trigger issues for testitem repos #569

Closed davidanthoff closed 3 months ago

davidanthoff commented 3 months ago

Repos that use the julia-vscode/testitem-workflow/.github/workflows/juliaci.yml are also TagBot enabled.

DilumAluthge commented 3 months ago

Hmmm. So, IIUC, this code is looking for the text JuliaRegistries/TagBot in the contents of the file (not the filename).

So I'm wondering why it's not already working, given that the https://github.com/julia-vscode/testitem-workflow/blob/main/.github/workflows/juliaci.yml file already includes the text JuliaRegistries/TagBot in the file contents.

DilumAluthge commented 3 months ago

Disregard my previous comment. I was looking at https://github.com/julia-vscode/testitem-workflow/blob/main/.github/workflows/juliaci.yml, but I should have been looking at https://github.com/davidanthoff/StringBuilders.jl/blob/master/.github/workflows/juliaci.yml.

And that latter file (https://github.com/davidanthoff/StringBuilders.jl/blob/master/.github/workflows/juliaci.yml) does indeed include the text (in its file contents) that this PR is looking for.

ericphanson commented 3 months ago

btw to be deployed, we need to first bump the version and merge & tag that

davidanthoff commented 3 months ago

Should I be doing something to trigger that? Probably makes more sense for someone who is more in charge of this repo to do that?

ericphanson commented 3 months ago

if it wasn't already merged I'd have asked you to include the version bump as part of the PR. Changes are infrequent currently so IMO it's better to just release whenever there's a change, otherwise it will be a long time until the next release.