Closed sloede closed 12 months ago
bump Who would be the right person to do a (first) review for this PR - @christopher-dG?
Looks good at a glance, but would be good to get review from @IanButterworth
Thanks for the merge @IanButterworth! It would be great if you could also create a new tag (I don't think I can do this as a PR, or can I?), such that it is usable in our workflows.
Yeah. I've messaged @christopher-dG because there's more to it than a PR AFAIK but I don't know what that is
OK, great, thanks a lot!
This PR enables users to manually specify a tag prefix, overriding the default tag prefix determination algorithm (the DTPDA, as it will henceforth be referred to as).
Before:
subdir=""
: tag prefix isv
, e.g.,v0.1.0
subdir="foo
": tag prefix isfoo-v
, e.g.,foo-v0.1.0
With this PR, there are additional options available through the
tag_prefix
input:tag_prefix=""
(default): as beforetag_prefix="bar"
: tag prefix isbar-v
, e.g.,bar-v0.1.0
(whatever the content ofsubdir
)tag_prefix="NO_PREFIX"
: tag prefix isv
, e.g.,v0.1.0
(whatever the content ofsubdir
)The main motivation is to allow users who have their Julia package in a subdirectory but want to tag their versions just as
v0.1.0
and not assubdir-v0.1.0
to use TagBot (which is an awesome action, thanks a lot to all maintainers!). This should be a non-breaking change, since the DTPDA remains unchanged if the new action inputtag_prefix
is not set.Resolves #278.
cc @bgeihe