search

JuliaRegistries / TagBot

Creates tags, releases, and changelogs for your Julia packages when they're registered
https://github.com/marketplace/actions/julia-tagbot
MIT License
91 stars 18 forks source link

show headers during GithubException #299

Closed IanButterworth closed 9 months ago

IanButterworth commented 9 months ago

Trying to check for information we currently ignore that could investigate https://github.com/JuliaRegistries/TagBot/issues/298

IanButterworth commented 9 months ago

My python knowledge is getting in the way

https://github.com/PyGithub/PyGithub/blob/673974918882d68826659daa5435e833cd7148c2/github/GithubException.py#L74C9-L74C16

>           logger.info(e.headers())
E           AttributeError: 'GithubException' object has no attribute 'headers'
DilumAluthge commented 9 months ago

Why version of pygithub are we using in our CI here?

IanButterworth commented 9 months ago

1.54.1 which doesn't store headers https://github.com/PyGithub/PyGithub/blob/34d097ce473601624722b90fc5d0396011dd3acb/github/GithubException.py

DilumAluthge commented 9 months ago

😭

DilumAluthge commented 9 months ago

What's the first version of pygithub that stores the headers?

IanButterworth commented 9 months ago

woo. Now we just need someone with a failing TagBot to try this out by setting TagBot@427ecaa29643c27fc588b03f43d071badfb3c7c9

IanButterworth commented 9 months ago

Or maybe we just release this as a patch and see in the wild

IanButterworth commented 9 months ago

Let's do it. It's green and we can revert in a patch if needed