JuliaReinforcementLearning / GridWorlds.jl

Help! I'm lost in the flatland!
MIT License
47 stars 9 forks source link

Refactor and Cleanup #114

Closed Sid-Bhatia-0 closed 3 years ago

Sid-Bhatia-0 commented 3 years ago
  1. import instead of using packages
    1. Much better clarity on the sources of types and methods. As in, what comes from which package.
    2. Makie 0.11.2 has Left and Right causing naming conflicts
    3. We can easily afford import since we don't have super heavy dependency on other packages
  2. Add AbstractDirection and make it the supertype of Up, Down, Left, Right. Deprecate Direction
  3. Add and use move and turn methods instead of functors for clarity.
  4. Remove exports that are not necessary for using the environments.
  5. merge PR #113 changes again since I forgot to rebase my branch for this PR 😅
codecov-io commented 3 years ago

Codecov Report

Merging #114 (086cf08) into master (756203a) will decrease coverage by 1.49%. The diff coverage is 56.97%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #114      +/-   ##
==========================================
- Coverage   79.40%   77.91%   -1.50%     
==========================================
  Files          17       17              
  Lines         845      797      -48     
==========================================
- Hits          671      621      -50     
- Misses        174      176       +2     
Impacted Files Coverage Δ
src/GridWorlds.jl 100.00% <ø> (ø)
src/grid_world_base.jl 94.73% <ø> (-0.39%) :arrow_down:
src/makie_rendering.jl 0.00% <0.00%> (ø)
src/abstract_grid_world.jl 75.00% <90.00%> (-1.48%) :arrow_down:
src/actions.jl 100.00% <100.00%> (ø)
src/directions.jl 100.00% <100.00%> (ø)
src/envs/collectgems.jl 100.00% <100.00%> (ø)
src/envs/doorkey.jl 100.00% <100.00%> (ø)
src/envs/dynamicobstacles.jl 97.40% <100.00%> (-0.13%) :arrow_down:
src/envs/emptyroom.jl 100.00% <100.00%> (ø)
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 756203a...086cf08. Read the comment docs.