search

JuliaReinforcementLearning / GridWorlds.jl

Help! I'm lost in the flatland!
MIT License
46 stars 9 forks source link

revamp CollectGemsUndirected & CollectGemsDirected #161

Closed Sid-Bhatia-0 closed 3 years ago

Sid-Bhatia-0 commented 3 years ago
  1. Remove old CollectGemsUndirected and CollectGemsDirected.
  2. Add new CollectGemsUndirectedModule.CollectGemsUndirected and CollectGemsDirectedModule.CollectGemsDirected.
  3. Update tests.
  4. Update README.

Here is how the new environments look:

CollectGemsUndirectedModule.CollectGemsUndirected:

collect_gems_undirected

CollectGemsDirectedModule.CollectGemsDirected:

collect_gems_directed

codecov-commenter commented 3 years ago

Codecov Report

Merging #161 (63ee439) into master (59e66bf) will decrease coverage by 0.68%. The diff coverage is 78.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #161      +/-   ##
==========================================
- Coverage   69.59%   68.90%   -0.69%     
==========================================
  Files          29       30       +1     
  Lines        2493     2515      +22     
==========================================
- Hits         1735     1733       -2     
- Misses        758      782      +24
Impacted Files Coverage Δ
src/envs/envs.jl 72.72% <ø> (ø)
src/envs/collect_gems_directed.jl 71.92% <71.92%> (ø)
src/envs/collect_gems_undirected.jl 81.08% <81.08%> (ø)
src/rlbase.jl 85.34% <87.50%> (+0.34%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 59e66bf...63ee439. Read the comment docs.