JuliaReinforcementLearning / GridWorlds.jl

Help! I'm lost in the flatland!
MIT License
46 stars 9 forks source link

revisiting interactivity: bug fixes and quality of life improvements #187

Closed Sid-Bhatia-0 closed 1 year ago

Sid-Bhatia-0 commented 1 year ago
  1. Fix type signature of frame_rate in replay method
  2. Add default value for frame_start_delimiter
  3. Prevent accidental overwrite of recording file
  4. Print frame number during replay
codecov[bot] commented 1 year ago

Codecov Report

Merging #187 (85620a6) into master (6c62515) will decrease coverage by 0.30%. The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #187      +/-   ##
==========================================
- Coverage   62.08%   61.78%   -0.30%     
==========================================
  Files          27       28       +1     
  Lines        2624     2685      +61     
==========================================
+ Hits         1629     1659      +30     
- Misses        995     1026      +31     
Impacted Files Coverage Δ
src/play.jl 0.00% <0.00%> (ø)

... and 14 files with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more