Closed Sid-Bhatia-0 closed 3 years ago
Merging #29 into master will increase coverage by
0.93%
. The diff coverage is0.00%
.
@@ Coverage Diff @@
## master #29 +/- ##
==========================================
+ Coverage 41.04% 41.98% +0.93%
==========================================
Files 10 10
Lines 268 262 -6
==========================================
Hits 110 110
+ Misses 158 152 -6
Impacted Files | Coverage Δ | |
---|---|---|
src/render_with_Makie.jl | 0.00% <0.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update b0a2d74...b0aa011. Read the comment docs.
This looks great!
This pull request is to simplify the
Makie
rendering process for objects. Instead of manually dispatching each object type (apart fromAgent
) usingif
statements and rendering it separately, this branch implements a default consistent rendering for an object (based on its character representation, as is done previously).A change that occurs with respect to the previous rendering is that walls are now
:white
(implied by itsget_color
method), as opposed to being:darkgray
earlier. Note that this default implementation can be easily overridden by explicitly checking for a particular object type. For example, in this case, we could add anif
statement to check for aWall
and manually set the color to:darkgray
. However, I feel that:white
doesn't look too bad (in my humble opinion :smile: )Overall, I believe this buys us a cleaner code and a consistent rendering across Makie and the terminal.