search

JuliaReinforcementLearning / GridWorlds.jl

Help! I'm lost in the flatland!
MIT License
46 stars 9 forks source link

PR regarding issue: Add DynamicObstacles #33 #42

Closed RajGhugare19 closed 3 years ago

RajGhugare19 commented 3 years ago

1) Added DynamicObstacles env

codecov-io commented 3 years ago

Codecov Report

Merging #42 into master will decrease coverage by 5.47%. The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #42      +/-   ##
==========================================
- Coverage   37.54%   32.06%   -5.48%     
==========================================
  Files          13       14       +1     
  Lines         293      343      +50     
==========================================
  Hits          110      110              
- Misses        183      233      +50
Impacted Files Coverage Δ
src/envs/doorkey.jl 0.00% <ø> (ø)
src/envs/dynamicobstacles.jl 0.00% <0.00%> (ø)
src/objects.jl 16.12% <0.00%> (-1.12%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2d004c7...332c716. Read the comment docs.

RajGhugare19 commented 3 years ago

@findmyway I think it should work now, please tell me if something is wrong, I had messed up the for loop :p (new to julia)

findmyway commented 3 years ago

Hi @RajGhugare19 ,

I think your latest commit works perfect now. 👍

Hmm... but why did you close this PR 😂