search

JuliaReinforcementLearning / GridWorlds.jl

Help! I'm lost in the flatland!
MIT License
46 stars 9 forks source link

Add RLBase get_terminal interface to CollectGems #43

Closed Sid-Bhatia-0 closed 3 years ago

Sid-Bhatia-0 commented 3 years ago

Adding a test file to convert from GridWorlds interface to ReinforcementLearningBase interface.

Also added a get_terminal method for the CollectGems environment to test whether the conversion is happening properly for MaxTimeoutEnv (see here).

This should be helpful in immediately testing an interface of GridWorlds.jl (interfaces of GridWorlds.jl will be written on the lines of ReinforcementLearningBase interface).

This moves us closer to the goal of enhanced connectivity and reusability among packages within JuliaReinforcementLearning. In this case, we can easily tap into the awesome functionalities offered by packages like ReinforcementLearningBase and ReinforcementLearningCore :smile:

Sid-Bhatia-0 commented 3 years ago

Yes. That is better. I've removed it from here.

codecov-io commented 3 years ago

Codecov Report

Merging #43 into master will decrease coverage by 0.25%. The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #43      +/-   ##
==========================================
- Coverage   37.54%   37.28%   -0.26%     
==========================================
  Files          13       13              
  Lines         293      295       +2     
==========================================
  Hits          110      110              
- Misses        183      185       +2
Impacted Files Coverage Δ
src/envs/collectgems.jl 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2d004c7...d13950e. Read the comment docs.