search

JuliaReinforcementLearning / GridWorlds.jl

Help! I'm lost in the flatland!
MIT License
46 stars 9 forks source link

Adding Dynamic Obstacle env, I closed the last one because my commits got a bit messy. #46

Closed RajGhugare19 closed 3 years ago

RajGhugare19 commented 3 years ago

I think this should work now, but tell me if anything is wrong

codecov-io commented 3 years ago

Codecov Report

Merging #46 into master will decrease coverage by 6.38%. The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #46      +/-   ##
==========================================
- Coverage   37.54%   31.16%   -6.39%     
==========================================
  Files          13       14       +1     
  Lines         293      353      +60     
==========================================
  Hits          110      110              
- Misses        183      243      +60
Impacted Files Coverage Δ
src/envs/doorkey.jl 0.00% <ø> (ø)
src/envs/dynamicobstacles.jl 0.00% <0.00%> (ø)
src/objects.jl 16.12% <0.00%> (-1.12%) :arrow_down:
src/envs/collectgems.jl 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2d004c7...ddb7a29. Read the comment docs.

RajGhugare19 commented 3 years ago

@findmyway I have made the final changes and fixed a few errors. :smiley:

findmyway commented 3 years ago

Cool! One final minor issue. It seems that in your GIF the obstacle may be placed in the same position of the GOAL. Could you add a check to avoid this case?

RajGhugare19 commented 3 years ago

@findmyway Ofcourse. Done