JuliaReinforcementLearning / ReinforcementLearningTrajectories.jl

A generalized experience replay buffer for reinforcement learning
MIT License
8 stars 8 forks source link

add more traces #9

Closed findmyway closed 2 years ago

codecov-commenter commented 2 years ago

Codecov Report

Merging #9 (c5d2a36) into main (edd4c52) will decrease coverage by 1.95%. The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main       #9      +/-   ##
==========================================
- Coverage   30.06%   28.10%   -1.96%     
==========================================
  Files           9       11       +2     
  Lines         316      338      +22     
==========================================
  Hits           95       95              
- Misses        221      243      +22     
Impacted Files Coverage Δ
src/common/ElasticArraySARTTraces.jl 0.00% <0.00%> (ø)
src/common/ReservoirTraces.jl 0.00% <0.00%> (ø)
src/trajectory.jl 81.48% <0.00%> (-10.19%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update edd4c52...c5d2a36. Read the comment docs.

HenriDeh commented 2 years ago

I was wondering if adding Traces that incorporate :action_log_prob into the defaults would not be appropriate ? Many algorithms use it so it should be useful to standardize the way they work I think.

findmyway commented 2 years ago

way

Sure, we can definitely add them