rishabhvarshney14 commented 3 years ago

Most of the algorithms have the same imports. So I moved all the imports from each individual algorithms to algorithms.jl

I am not sure if doing this will have any kind of effects. Thank You.

codecov-io commented 3 years ago

Codecov Report

Merging #130 (b0fa382) into master (2f6c1e2) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #130   +/-   ##
=======================================
  Coverage   66.84%   66.84%           
=======================================
  Files          30       30           
  Lines        1894     1894           
=======================================
  Hits         1266     1266           
  Misses        628      628

Impacted Files	Coverage Δ
src/algorithms/cfr/best_response_policy.jl	`88.46% <ø> (ø)`
src/algorithms/cfr/deep_cfr.jl	`0.00% <ø> (ø)`
src/algorithms/cfr/external_sampling_mccfr.jl	`97.29% <ø> (ø)`
src/algorithms/cfr/outcome_sampling_mccfr.jl	`97.36% <ø> (ø)`
src/algorithms/dqns/basic_dqn.jl	`96.77% <ø> (ø)`
src/algorithms/dqns/dqn.jl	`91.17% <ø> (ø)`
src/algorithms/dqns/iqn.jl	`90.66% <ø> (ø)`
src/algorithms/dqns/prioritized_dqn.jl	`88.88% <ø> (ø)`
src/algorithms/dqns/rainbow.jl	`94.11% <ø> (ø)`
src/algorithms/policy_gradient/A2C.jl	`87.50% <ø> (ø)`
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2f6c1e2...b0fa382. Read the comment docs.

findmyway commented 3 years ago

Thanks!

I'll apply this change after https://github.com/JuliaReinforcementLearning/ReinforcementLearningZoo.jl/pull/129

JuliaReinforcementLearning / ReinforcementLearningZoo.jl

Removed repetitive imports from algorithms. #130

Codecov Report