Closed moustachio-belvedere closed 1 year ago
thanks @moustachio-belvedere . I can't reproduce the error on 1.8. Is it still an issue for you?
I'll fix the warnings.
Sorry @moustachio-belvedere , I realise I did not test on the public release. So this most likely remains a problem. The issue is that we try to write on the package folder, which in hindsight seems inadequate.
I think a better solution might be to generate a random temporary file name for the test (in a suitable location in the computer), use it and delete the file when the test is complete.
I believe tempname()
would return such a filename.
Tempname sounds like a good solution to me 👍
Tests are passing with the new temp file. I assume that it should now resolve the error, to be fully tested on the next public release.
When running the test suite on Julia 1.7.3 some new warnings and errors are raised.
Warnings where we should be using the more generic
values
andkeys
functions onkwargs
. For example:Error arises from permissions bits on the test data files:
It seems that when you install the release version of RHEOS using
]add RHEOS
all files have only read permission on Linux. Changing the permissions bits to be more flexible resolves this error. To fix this we could do a permissions test first and fail gracefully with a test skipped warning if it detects that the test data doesn't have the correct permissions. This is essentially a proxy test for whether the RHEOS version is from the Julia respository (public release) or from agit clone
(for development).