search

JuliaRheology / RHEOS.jl

RHEOS - Open Source Rheology data analysis software
MIT License
39 stars 9 forks source link

Do we need really python to generate the doc's graphs? #161

Closed akabla closed 6 months ago

akabla commented 6 months ago

Following some investigations for issue #160 , I removed the eye candy using python and PyCall to center one of the plots. I simply placed the three plots on top of each other. It works better for mobile devices, and keeps the documentation simpler to maintain.

@alebonfanti , @moustachio-belvedere , any views?

moustachio-belvedere commented 6 months ago

Looks fine to me! Thanks Alexandre

moustachio-belvedere commented 6 months ago

BTW, I'm not sure why but there's some installation output showing in the newly built docs that wasn't there before: https://juliarheology.github.io/RHEOS.jl/dev/examples/

akabla commented 6 months ago

Thanks Louis. That's new indeed.

alebonfanti commented 6 months ago

Looks good to me as well! Thanks!

akabla commented 6 months ago

In fact, I'm wondering if we should not switch to Gadfly or something similar for the tutorials. It may also help with #163.

alebonfanti commented 6 months ago

what do you think of Plots.jl?

akabla commented 6 months ago

Plots is great, but seems to be big - with many different backends. I was thinking about a package written in pure julia to remove dependencies as much as possible. Makie looks actually good.

moustachio-belvedere commented 6 months ago

I don't have a preference but good to note the main advantage of PyPlot is that it is more familiar to people with a Python background

akabla commented 6 months ago

To note that there is also a package called PythonPlot, based on PythonCall, an alternative to PyCall. I'm closing this as this was all triggered by issues with the doc generation, which is now working fine. We can revisit this later if needed.