search

JuliaRheology / RHEOS.jl

RHEOS - Open Source Rheology data analysis software
MIT License
39 stars 9 forks source link

Installation output showing in the newly built docs #163

Open akabla opened 6 months ago

akabla commented 6 months ago 
          BTW, I'm not sure why but there's some installation output showing in the newly built docs that wasn't there before:

https://juliarheology.github.io/RHEOS.jl/dev/examples/

Originally posted by @moustachio-belvedere in https://github.com/JuliaRheology/RHEOS.jl/issues/161#issuecomment-1975304989

akabla commented 6 months ago

I tried to stop this output with ";", but it doesn't help here.

moustachio-belvedere commented 6 months ago

I found updating the docs/ project environment to remove Conda and PyCall (possible now due to your removal of explicit PyCall usage) and upgrading didn't produce the output locally which is promising.

moustachio-belvedere commented 6 months ago

If this doesn't help on the remote build I think we can get the CI pipeline to force an early PyPlot installation before the doc build gets triggered

moustachio-belvedere commented 6 months ago

Actually, adding this near the top of docs/make.jl might be better than changing CI:

using Pkg
ENV["PYTHON"]=""
Pkg.build("PyCall")
using PyCall
pyimport_conda("matplotlib.pyplot", "matplotlib")
akabla commented 6 months ago

Actually, adding this near the top of docs/make.jl might be better than changing CI:

using Pkg
ENV["PYTHON"]=""
Pkg.build("PyCall")
using PyCall
pyimport_conda("matplotlib.pyplot", "matplotlib")

Thanks Louis, that fixed it!

We might as well simplify the environment and remove Conda and Pycall. I leave this open for now.

moustachio-belvedere commented 6 months ago

Sounds good. Though I think with the above fix we'll have to leave PyCall in as an explicit dependency. (Conda will still be a dependency but can prob be relegated to an implicit one.)