search

JuliaRobotics / DistributedFactorGraphs.jl

Abstraction layer for spanning factor graphs over various technologies
Apache License 2.0
21 stars 2 forks source link

updateDataEntry! should not be allowed? #404

Open dehann opened 4 years ago

dehann commented 4 years ago

Did we decide that data entries are immutable and should not updatable?

This was big enough to be dubbed the "Falmouth Manifesto" a while back

dehann commented 4 years ago

perhaps a better verb here would be replaceDataEntry!? The idea being that replacement means the unique object identifier that is used is changed and the user is also aware that the old data is no longer available. This gets a little tricky when trying to work with the description label only -- e.g. add entry :RADAR to dfg object and push it up to server, Then the server changes :RADAR and how is client supposed to know (and visa verse).

Affie commented 4 years ago

Perhaps DFG "core" should just remain vanilla with normal CRUD. The smarter functionality can then be added in the next layers such as CloudGraphsDFG for example.

dehann commented 4 years ago

what is the different between updateData! and updateDataEntry! ?

maybe rename to _updateDataEntry!?

Affie commented 4 years ago

what is the different between updateData! and updateDataEntry! ?

updateData! updates a data blob and entry updateDataEntry! updates a data entry

Affie commented 2 months ago

Only blobs are currently immutable, BlobEntries are mutable, therefore update should be allowed. For example, one can update the metadata.