Open Affie opened 4 years ago
hi, thanks for finding this. although this needs work, i would recommend deferring the effort in the short term and only return to consolidate cgdfg subgraph when it becomes really necessary or sensible to do so. If we can limp along on current cgdfg implementation for a while, that should be okay.
It looks like more of a maintenance thing with the functions missed with the deletion of the deprecations.
However, CGDFG can still overwrite buildSubgraph
and/or copyGraph!
for performance.
Also listing here in case it isn't/hasn't been elsewhere for DFG:
https://github.com/JuliaRobotics/DistributedFactorGraphs.jl/blob/eaea68c09d712532a2ad73338b0298da43e0e37a/src/CloudGraphsDFG/services/CloudGraphsDFG.jl#L465-L492
see