JuliaRobotics / DistributedFactorGraphs.jl

Abstraction layer for spanning factor graphs over various technologies
Apache License 2.0
22 stars 2 forks source link

Deprecated subgraph functions in CGDFG #650

Open Affie opened 4 years ago

Affie commented 4 years ago

https://github.com/JuliaRobotics/DistributedFactorGraphs.jl/blob/eaea68c09d712532a2ad73338b0298da43e0e37a/src/CloudGraphsDFG/services/CloudGraphsDFG.jl#L465-L492

see

dehann commented 4 years ago

hi, thanks for finding this. although this needs work, i would recommend deferring the effort in the short term and only return to consolidate cgdfg subgraph when it becomes really necessary or sensible to do so. If we can limp along on current cgdfg implementation for a while, that should be okay.

Affie commented 4 years ago

It looks like more of a maintenance thing with the functions missed with the deletion of the deprecations.

However, CGDFG can still overwrite buildSubgraph and/or copyGraph! for performance.

dehann commented 4 years ago

Also listing here in case it isn't/hasn't been elsewhere for DFG: