JuliaSIMD / ThreadingUtilities.jl

Utilities for low overhead threading in Julia.
MIT License
17 stars 4 forks source link

Several fixes for CI #2

Closed DilumAluthge closed 3 years ago

DilumAluthge commented 3 years ago
  1. Test on the 1.6 beta
  2. Split the Julia nightly testing into a separate workflow file
  3. Fix the docs build
  4. Set a timeout of 30 minutes per job. (We can always increase this. I put this in because some of the jobs are timing out at 6 hours, which ends up wasting CI time.)
codecov-io commented 3 years ago

Codecov Report

Merging #2 (6d4f146) into master (23434f6) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master       #2   +/-   ##
=======================================
  Coverage   96.93%   96.93%           
=======================================
  Files           3        3           
  Lines          98       98           
=======================================
  Hits           95       95           
  Misses          3        3           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 23434f6...11fb3f2. Read the comment docs.

chriselrod commented 3 years ago
4\. Set a timeout of 30 minutes per job. (We can always increase this. I put this in because some of the jobs are timing out at 6 hours, which ends up wasting CI time.)

More likely we should shorten it, because of they don't finish very quickly, it probably got stuck and will never finish. Seems to suggest there is a bug.

DilumAluthge commented 3 years ago
4\. Set a timeout of 30 minutes per job. (We can always increase this. I put this in because some of the jobs are timing out at 6 hours, which ends up wasting CI time.)

More likely we should shorten it, because of they don't finish very quickly, it probably got stuck and will never finish. Seems to suggest there is a bug.

I've shortened it to 10 minutes.

chriselrod commented 3 years ago

I'll go ahead and merge this to waste less CI time. I'll have to see went it's failing. I've not had it get stuck locally.

I'll probably have to add counters with asserts in a few loops to try and get error messages on CI.

DilumAluthge commented 3 years ago

I'll go ahead and merge this to waste less CI time.

Yeah, the GitHub Actions global concurrency limit of 20 simultaneous jobs applies to all repositories on your account, so if jobs time out to 6 hours, it'll slow down the CI on all of your repos.