search

JuliaSIMD / VectorizedRNG.jl

Vectorized uniform and normal random samplers.
MIT License
33 stars 7 forks source link

missing arguments in rand! methods for StaticArrays #27

Closed schrimpf closed 11 months ago

schrimpf commented 11 months ago

The rand! methods for StaticArrays beginning on line 398 of api.jl don't define α, β, and γ, but use them in the call to samplevector!.

chriselrod commented 11 months ago

That's a definite bug. Would you be willing to make a PR fixing that and adding tests by any chance?

schrimpf commented 11 months ago

Sure.

chriselrod commented 11 months ago

If you're feeling particularly ambitious, you could also turn the StaticArraysCore dependency into a weakdep/PkgExtension, so that it only gets loaded when someone is actually using StaticArrays. https://julialang.org/blog/2023/04/julia-1.9-highlights/#package_extensions

But absolutely no pressure, any contributions welcome. I don't like letting the desire for immediate perfection be the enemy of progress.