JuliaServices / AutoHashEquals.jl

A Julia macro to add == and hash() to composite types.
Other
57 stars 12 forks source link

Broken on 0.5 #4

Closed davidanthoff closed 7 years ago

davidanthoff commented 8 years ago

Seems to be broken on the latest nightly build (and has been for about a week for me):

               _
   _       _ _(_)_     |  A fresh approach to technical computing
  (_)     | (_) (_)    |  Documentation: http://docs.julialang.org
   _ _   _| |_  __ _   |  Type "?help" for help.
  | | | | | | |/ _` |  |
  | | |_| | | | (_| |  |  Version 0.5.0-dev+3839 (2016-05-02 16:25 UTC)
 _/ |\__'_|_|_|\__'_|  |  Commit 6bc704d* (0 days old master)
|__/                   |  x86_64-w64-mingw32

julia> Pkg.test("AutoHashEquals")
INFO: Computing test dependencies for AutoHashEquals...
INFO: No packages to install, update or remove
INFO: Testing AutoHashEquals
ERROR: LoadError: UndefVarError: expand not defined
 in include(::ASCIIString) at .\boot.jl:233
 in include_from_node1(::UTF8String) at .\loading.jl:426
 in process_options(::Base.JLOptions) at .\client.jl:263
 in _start() at .\client.jl:319
while loading C:\Users\anthoff\.julia\v0.5\AutoHashEquals\test\runtests.jl, in expression starting on line 14
=============================================================[ ERROR: AutoHashEquals ]=============================================================

failed process: Process(`'C:\Users\anthoff\AppData\Local\julia-dev\bin\julia' -Cx86-64 '-JC:\Users\anthoff\AppData\Local\julia-dev\lib\julia\sys.dll' --compile=yes --check-bounds=yes --code-coverage=none --color=yes 'C:\Users\anthoff\.julia\v0.5\AutoHashEquals\test\runtests.jl'`, ProcessExited(1)) [1]

===================================================================================================================================================
INFO: No packages to install, update or remove
ERROR: Base.Pkg.PkgError("AutoHashEquals had test errors")
 [inlined code] from .\strings\io.jl:33
 in #test#49(::Bool, ::Function, ::Array{AbstractString,1}) at .\pkg\entry.jl:678
 [inlined code] from .\promotion.jl:229
 in (::Base.Pkg.Dir.##2#3{Array{Any,1},Base.Pkg.Entry.#test,Tuple{Array{AbstractString,1}}})() at .\pkg\dir.jl:31
 in cd(::Base.Pkg.Dir.##2#3{Array{Any,1},Base.Pkg.Entry.#test,Tuple{Array{AbstractString,1}}}, ::ASCIIString) at .\file.jl:58
 in #cd#1(::Array{Any,1}, ::Function, ::Function, ::Array{AbstractString,1}, ::Vararg{Array{AbstractString,1}}) at .\pkg\dir.jl:31
 in #test#3(::Bool, ::Function, ::ASCIIString, ::Vararg{ASCIIString}) at .\pkg.jl:228
 in eval(::Module, ::Any) at .\boot.jl:236
andrewcooke commented 8 years ago

thanks, i'll have a look (not sure when, but within the next 2 weeks!)

andrewcooke commented 8 years ago

hmmm. but it's still broken, with a different error, which looks like it's related to inline documentation.

andrewcooke commented 8 years ago

as far as i can tell from http://docs.julialang.org/en/latest/manual/documentation/?highlight=docstring the current code should still work. i can't find an appropriate issue. will come back later in the hope it fixes itself in the next day or two...

davidanthoff commented 8 years ago

So, I think the bug that I found should be fixed because of this https://github.com/JuliaLang/julia/issues/16158. Might make sense to try this out with the new nightly build tomorrow, at least the error I reported here might just be gone away.

andrewcooke commented 8 years ago

yes - i tried it yesterday with the latest from github. however there's another problem with doc strings. but that only affects the tests (you can use the package).

davidanthoff commented 8 years ago

Ah, excellent!

andrewcooke commented 7 years ago

not sure why this is still open.