search

JuliaServices / AutoHashEquals.jl

A Julia macro to add == and hash() to composite types.
Other
58 stars 12 forks source link

Make package explicitly precompilable #5

Closed iamed2 closed 8 years ago

iamed2 commented 8 years ago

Loading a certain big dependency tree including AutoHashEquals was failing on 0.5. This fixes that.

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-2.8%) to 91.667% when pulling 51f5a54bebb905b7376fde708e9dce4e897765b7 on iamed2:patch-1 into bbad56cd5ce985369971045132f1b4407b95f50d on andrewcooke:master.

coveralls commented 8 years ago

Coverage Status

Coverage increased (+0.2%) to 94.595% when pulling cd54d9ed2b4284b33488717236801679cb217302 on iamed2:patch-1 into bbad56cd5ce985369971045132f1b4407b95f50d on andrewcooke:master.

coveralls commented 8 years ago

Coverage Status

Coverage increased (+0.2%) to 94.595% when pulling cd54d9ed2b4284b33488717236801679cb217302 on iamed2:patch-1 into bbad56cd5ce985369971045132f1b4407b95f50d on andrewcooke:master.

iamed2 commented 8 years ago

I'll note that I couldn't get the docstring test working for 0.5 in any format so I marked it as broken.

iamed2 commented 8 years ago

Thanks! :)

andrewcooke commented 8 years ago

tagging now (ish)...

iamed2 commented 8 years ago

Double thanks! :)

andrewcooke commented 8 years ago

Pkg.publish() is broken in 0.4.

With 0.5 I am seeing invalid metdata from another package (DataFrames requires BayesNets which apparently does not exist).

This kind of crap is why I spend my time elsewhere these days. I'll try again tomorrow.

iamed2 commented 8 years ago

I understand your frustration!

If you felt comfortable, you could give me contributor access and I could do it, and assist in maintaining this repo. I understand if you don't want to do that though.

andrewcooke commented 8 years ago

hat would be great - just sent you an invite, i think.

iamed2 commented 8 years ago

Yep, got it. Thanks!

andrewcooke commented 8 years ago

not sure if it's clear, but there's a 0.0.10 (iirc) in git. that was created by PkgDev,tag(). you may want to delete that from git and then run tag and publish yourself. i imagine there are more complicated ways but that's what i was trying to do. thanks.

iamed2 commented 8 years ago

I didn't have to delete it because the 0.0.10 tag didn't exist on GitHub. You must not have pushed it.