search

JuliaServices / AutoHashEquals.jl

A Julia macro to add == and hash() to composite types.
Other
57 stars 12 forks source link

get rid of Pkg dependency #52

Open KristofferC opened 4 weeks ago

KristofferC commented 4 weeks ago

we can use Base.pkgversion if we restrict ourselves to julia 1.9+

KristofferC commented 1 week ago

@NHDaly, do you still have commit access to this repo?

NHDaly commented 3 days ago

Looks to have some failures on nightly, but I assume they're unrelated? Can you confirm?:

macro preserves comments 1: Test Failed at /home/runner/work/AutoHashEquals.jl/AutoHashEquals.jl/test/runtests.jl:79
  Expression: plain(#= /home/runner/work/AutoHashEquals.jl/AutoHashEquals.jl/test/runtests.jl:79 =# @doc(T23)) == "a comment\n"
   Evaluated: "Base.Docs.DocStr(svec(\"a comment\"), nothing, Dict{Symbol, Any}(:typesig => Union{}, :module => Main.runtests, :linenumber => 75, :binding => Main.runtests.T23, :path => \"/home/runner/work/AutoHashEquals.jl/AutoHashEquals.jl/test/runtests.jl\"))\n" == "a comment\n"
NHDaly commented 3 days ago

:) Thanks for the PR, Kristoffer!