JuliaServices / Match.jl

Advanced Pattern Matching for Julia
https://juliaservices.github.io/Match.jl/latest/
Other
240 stars 22 forks source link

Complete overhaul of implementation taken from Rematch2.jl #78

Closed gafter closed 1 year ago

gafter commented 1 year ago
codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: +20.62% :tada:

Comparison is base (6f0c04e) 79.37% compared to head (7bac0a1) 100.00%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #78 +/- ## ============================================ + Coverage 79.37% 100.00% +20.62% ============================================ Files 3 12 +9 Lines 286 1036 +750 ============================================ + Hits 227 1036 +809 + Misses 59 0 -59 ``` | [Files Changed](https://app.codecov.io/gh/JuliaServices/Match.jl/pull/78?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaServices) | Coverage Δ | | |---|---|---| | [src/Match.jl](https://app.codecov.io/gh/JuliaServices/Match.jl/pull/78?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaServices#diff-c3JjL01hdGNoLmps) | `100.00% <100.00%> (ø)` | | | [src/automaton.jl](https://app.codecov.io/gh/JuliaServices/Match.jl/pull/78?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaServices#diff-c3JjL2F1dG9tYXRvbi5qbA==) | `100.00% <100.00%> (ø)` | | | [src/binding.jl](https://app.codecov.io/gh/JuliaServices/Match.jl/pull/78?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaServices#diff-c3JjL2JpbmRpbmcuamw=) | `100.00% <100.00%> (ø)` | | | [src/bound\_pattern.jl](https://app.codecov.io/gh/JuliaServices/Match.jl/pull/78?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaServices#diff-c3JjL2JvdW5kX3BhdHRlcm4uamw=) | `100.00% <100.00%> (ø)` | | | [src/immutable\_vector.jl](https://app.codecov.io/gh/JuliaServices/Match.jl/pull/78?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaServices#diff-c3JjL2ltbXV0YWJsZV92ZWN0b3Iuamw=) | `100.00% <100.00%> (ø)` | | | [src/lowering.jl](https://app.codecov.io/gh/JuliaServices/Match.jl/pull/78?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaServices#diff-c3JjL2xvd2VyaW5nLmps) | `100.00% <100.00%> (ø)` | | | [src/match\_cases\_opt.jl](https://app.codecov.io/gh/JuliaServices/Match.jl/pull/78?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaServices#diff-c3JjL21hdGNoX2Nhc2VzX29wdC5qbA==) | `100.00% <100.00%> (ø)` | | | [src/match\_cases\_simple.jl](https://app.codecov.io/gh/JuliaServices/Match.jl/pull/78?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaServices#diff-c3JjL21hdGNoX2Nhc2VzX3NpbXBsZS5qbA==) | `100.00% <100.00%> (ø)` | | | [src/match\_return.jl](https://app.codecov.io/gh/JuliaServices/Match.jl/pull/78?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaServices#diff-c3JjL21hdGNoX3JldHVybi5qbA==) | `100.00% <100.00%> (ø)` | | | [src/matchmacro.jl](https://app.codecov.io/gh/JuliaServices/Match.jl/pull/78?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaServices#diff-c3JjL21hdGNobWFjcm8uamw=) | `100.00% <100.00%> (+19.90%)` | :arrow_up: | | ... and [2 more](https://app.codecov.io/gh/JuliaServices/Match.jl/pull/78?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaServices) | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

gafter commented 1 year ago

@mcmcgrath13 Please review. This is almost exactly just moving the code from Rematch2.jl.

quinnj commented 1 year ago

Great stuff. The typical pattern for Julia packages is to actually hold off on doing the actual git tag until the General registry update is done (and then let the TagBot GHA do the git tag for us). So let me know if you want any help with publishing the upgrade?