JuliaSmoothOptimizers / ADNLPModels.jl

Other
29 stars 12 forks source link

Setup in-place constructors #101

Closed tmigot closed 1 year ago

github-actions[bot] commented 1 year ago
Package name latest stable
CaNNOLeS.jl
DCISolver.jl
DerivativeFreeSolvers.jl
JSOSolvers.jl
NLPModelsIpopt.jl
OptimizationProblems.jl
Percival.jl
QuadraticModels.jl
SolverBenchmark.jl
SolverTools.jl
codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 93.58% and project coverage change: -1.09 :warning:

Comparison is base (ffddfc6) 99.46% compared to head (2c12ac9) 98.37%.

:exclamation: Current head 2c12ac9 differs from pull request most recent head ec2dd67. Consider uploading reports for the commit ec2dd67 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #101 +/- ## ========================================== - Coverage 99.46% 98.37% -1.09% ========================================== Files 8 8 Lines 748 862 +114 ========================================== + Hits 744 848 +104 - Misses 4 14 +10 ``` | [Impacted Files](https://codecov.io/gh/JuliaSmoothOptimizers/ADNLPModels.jl/pull/101?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaSmoothOptimizers) | Coverage Δ | | |---|---|---| | [src/nls.jl](https://codecov.io/gh/JuliaSmoothOptimizers/ADNLPModels.jl/pull/101?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaSmoothOptimizers#diff-c3JjL25scy5qbA==) | `98.27% <90.62%> (-1.73%)` | :arrow_down: | | [src/nlp.jl](https://codecov.io/gh/JuliaSmoothOptimizers/ADNLPModels.jl/pull/101?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaSmoothOptimizers#diff-c3JjL25scC5qbA==) | `98.55% <93.54%> (-1.45%)` | :arrow_down: | | [src/ADNLPModels.jl](https://codecov.io/gh/JuliaSmoothOptimizers/ADNLPModels.jl/pull/101?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaSmoothOptimizers#diff-c3JjL0FETkxQTW9kZWxzLmps) | `100.00% <100.00%> (ø)` | | | [src/ad.jl](https://codecov.io/gh/JuliaSmoothOptimizers/ADNLPModels.jl/pull/101?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaSmoothOptimizers#diff-c3JjL2FkLmps) | `97.10% <100.00%> (+0.13%)` | :arrow_up: | | [src/sparse\_derivatives.jl](https://codecov.io/gh/JuliaSmoothOptimizers/ADNLPModels.jl/pull/101?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaSmoothOptimizers#diff-c3JjL3NwYXJzZV9kZXJpdmF0aXZlcy5qbA==) | `100.00% <100.00%> (ø)` | | | [src/zygote.jl](https://codecov.io/gh/JuliaSmoothOptimizers/ADNLPModels.jl/pull/101?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaSmoothOptimizers#diff-c3JjL3p5Z290ZS5qbA==) | `100.00% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaSmoothOptimizers). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaSmoothOptimizers)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

tmigot commented 1 year ago

a) The error with DCISolver is the following:

f(x) = (x[1] - 1)^2 + 4 * (x[2] - x[1]^2)^2
nlp = ADNLPModel(f, [-1.2; 1.0])
hess(nlp, nlp.meta.x0, nlp.meta.y0)

b) The support with Zygote would be broken as it doesn't support broadcast. The only solution would be to pass ADNLPModel! with a c! that doesn't use broadcast.

github-actions[bot] commented 1 year ago
Package name latest stable
CaNNOLeS.jl
DCISolver.jl
DerivativeFreeSolvers.jl
JSOSolvers.jl
NLPModelsIpopt.jl
OptimizationProblems.jl
Percival.jl
QuadraticModels.jl
SolverBenchmark.jl
SolverTools.jl