Closed tmigot closed 1 year ago
Patch coverage: 96.15
% and project coverage change: -0.07
:warning:
Comparison is base (
f805c74
) 98.50% compared to head (b53875f
) 98.44%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
@amontoison I am finally ready with this! I think it will not be hard to do the same for the Hessian, later.
Awesome!!! Would you mind adding a couple of unit tests? They serve as documentation too.
Tangi, why do you call this backend
SparseForwardADJacobian
? We can decide if we want to determine the Jacobian by rows or columns.matrix_colors(A,alg; partition_by_rows)
Because it uses a forward-mode autodiff to compute the values.
That's right, I can add these options in the backend constructor, thanks for the suggestion.
Hey @amontoison ! I added the algorithm in kwargs and tests. However, no clue how to make the partition_by_rows
work, so I created an issue in SparseDiffTools. So, I guess it is for later :).
Thanks @amontoison for the improvements!
13