Use ColPack instead of SparseDiffTools for coloration

tmigot commented 1 year ago

This will simplify the dependencies of the package.

I will add SparseDiffTools as an optional dependency after this one.

Some results: https://github.com/JuliaSmoothOptimizers/ADNLPModels.jl/blob/benchmark/benchmark/coloration.jl https://github.com/JuliaSmoothOptimizers/ADNLPModels.jl/blob/benchmark/benchmark/coloration1000.dat

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.02 :tada:

Comparison is base (4cbb2d8) 97.12% compared to head (a8579e7) 97.15%.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #166 +/- ## ========================================== + Coverage 97.12% 97.15% +0.02% ========================================== Files 11 11 Lines 1391 1404 +13 ========================================== + Hits 1351 1364 +13 Misses 40 40 ``` | [Impacted Files](https://app.codecov.io/gh/JuliaSmoothOptimizers/ADNLPModels.jl/pull/166?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaSmoothOptimizers) | Coverage Δ | | |---|---|---| | [src/ADNLPModels.jl](https://app.codecov.io/gh/JuliaSmoothOptimizers/ADNLPModels.jl/pull/166?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaSmoothOptimizers#diff-c3JjL0FETkxQTW9kZWxzLmps) | `100.00% <ø> (ø)` | | | [src/ad.jl](https://app.codecov.io/gh/JuliaSmoothOptimizers/ADNLPModels.jl/pull/166?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaSmoothOptimizers#diff-c3JjL2FkLmps) | `100.00% <100.00%> (ø)` | | | [src/sparse\_hessian.jl](https://app.codecov.io/gh/JuliaSmoothOptimizers/ADNLPModels.jl/pull/166?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaSmoothOptimizers#diff-c3JjL3NwYXJzZV9oZXNzaWFuLmps) | `92.78% <100.00%> (ø)` | | | [src/sparse\_jacobian.jl](https://app.codecov.io/gh/JuliaSmoothOptimizers/ADNLPModels.jl/pull/166?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaSmoothOptimizers#diff-c3JjL3NwYXJzZV9qYWNvYmlhbi5qbA==) | `100.00% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

github-actions[bot] commented 1 year ago

Package name	latest	stable
CaNNOLeS.jl
DCISolver.jl
DerivativeFreeSolvers.jl
JSOSolvers.jl
NLPModelsIpopt.jl
OptimizationProblems.jl
Percival.jl
QuadraticModels.jl
SolverBenchmark.jl
SolverTools.jl

tmigot commented 1 year ago

Benchmarks: https://github.com/JuliaSmoothOptimizers/ADNLPModels.jl/blob/benchmark/benchmark/2023-06-23_adnlpmodels_benchmark_jac_nscal_1000_mono.png

https://github.com/JuliaSmoothOptimizers/ADNLPModels.jl/blob/benchmark/benchmark/2023-06-23_adnlpmodels_benchmark_hess_nscal_1000_mono.png

amontoison commented 1 year ago

Except a minor comment, it's fine for me Tangi. Thanks!

amontoison commented 1 year ago

@tmigot You removed a lot of dependencies after this PR :+1:

(@v1.9) pkg> dev .
   Resolving package versions...
  No Changes to `~/.julia/environments/v1.9/Project.toml`
    Updating `~/.julia/environments/v1.9/Manifest.toml`
  [ec485272] - ArnoldiMethod v0.2.0
  [6a86dc24] - FiniteDiff v2.21.1
  [86223c79] - Graphs v1.8.0
  [d25df0c9] - Inflate v0.1.3
  [699a6c99] - SimpleTraits v0.9.4
  [47a9eef4] - SparseDiffTools v2.4.0
  [aedffcd0] - Static v0.8.7
  [0d7ed370] - StaticArrayInterface v1.4.0
  [19fa3120] - VertexSafeGraphs v0.2.0
  [1a1011a3] - SharedArrays

JuliaSmoothOptimizers / ADNLPModels.jl

Use ColPack instead of SparseDiffTools for coloration #166

Codecov Report