Open kiranshila opened 1 month ago
Actually, I think this is way harder than I expected because of all the new data types. It seems like this might need some serious restructuring to fit into the package extension style.
Hi @kiranshila ! Thanks for working on this. Droping Julia version before 1.9 is a big decision though that I would prefer to delay for the moment if that's ok for you?
I took the liberty of also removing the test Project.toml as current best practice is to define all the dependencies (including test deps) in the top level toml file and use extras and targets.
Do you have any link related to this?
Since Julia 1.9, the recommended way to have optional dependencies and additional code that adds support for those optional dependencies is Package Extensions. This is a WIP PR to reorganize ADNLPModels to support them.
There are several benefits. First, the ability to precompile the extensions decreases the TTFx of code using the extensions, which is always good. Second, we can specify compat of the extensions' dependencies. This is really useful as AD backends like Enzyme are a little unstable and benefit from explicit, tagged versions.
Current Blockers
Additional Edits
I took the liberty of also removing the test
Project.toml
as current best practice is to define all the dependencies (including test deps) in the top level toml file and useextras
andtargets
.