tmigot commented 2 years ago

Finally, the update with the linear API. Again this is a large PR so here is a recap':

I updated all the problems in test folder to match the linear API.
We now have SparseArrays in the deps
ADNLPModel and ADNLSModel store four vectors for the linear constraint function Ax + blin
There are two new constructor per model + two extras when the user passes a matrix instead of the COO-triplet
I removed the possibility to provide linear constraints via the lin keyword.
The rest is the implementation of the linear API (recall that for efficiency we also reimplement jtprod!).

codecov[bot] commented 2 years ago

Codecov Report

Merging #66 (6111885) into main (b2444c1) will decrease coverage by 0.93%. The diff coverage is 98.26%.

:exclamation: Current head 6111885 differs from pull request most recent head c4979b6. Consider uploading reports for the commit c4979b6 to get more accurate results

@@            Coverage Diff             @@
##             main      #66      +/-   ##
==========================================
- Coverage   99.18%   98.24%   -0.94%     
==========================================
  Files           7        7              
  Lines         489      685     +196     
==========================================
+ Hits          485      673     +188     
- Misses          4       12       +8

Impacted Files	Coverage Δ
src/ADNLPModels.jl	`100.00% <ø> (ø)`
src/nlp.jl	`98.29% <98.23%> (-1.71%)`	:arrow_down:
src/nls.jl	`98.65% <98.27%> (-1.35%)`	:arrow_down:
src/ad.jl	`94.73% <100.00%> (+0.29%)`	:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

github-actions[bot] commented 2 years ago

Package name	latest	stable
CaNNOLeS.jl
DCISolver.jl
DerivativeFreeSolvers.jl
JSOSolvers.jl
NLPModelsIpopt.jl
OptimizationProblems.jl
Percival.jl
QuadraticModels.jl
SolverBenchmark.jl
SolverTools.jl

github-actions[bot] commented 2 years ago

Package name	latest	stable
CaNNOLeS.jl
DCISolver.jl
DerivativeFreeSolvers.jl
JSOSolvers.jl
NLPModelsIpopt.jl
OptimizationProblems.jl
Percival.jl
QuadraticModels.jl
SolverBenchmark.jl
SolverTools.jl

github-actions[bot] commented 2 years ago

Package name	latest	stable
CaNNOLeS.jl
DCISolver.jl
DerivativeFreeSolvers.jl
JSOSolvers.jl
NLPModelsIpopt.jl
OptimizationProblems.jl
Percival.jl
QuadraticModels.jl
SolverBenchmark.jl
SolverTools.jl