JuliaSmoothOptimizers / BundleAdjustmentModels.jl

Julia repository of bundle adjustment problems
Mozilla Public License 2.0
9 stars 5 forks source link

Bump version 0.2 #50

Closed AntoninKns closed 2 years ago

AntoninKns commented 2 years ago

Bumping version of BundleAdjustmentModels to 0.2. Concerning the version of the dependancies I was wondering if we force NLPModels 0.19 or if we allow a broader range of versions. It is important to notice that having NLPModels version 0.18 or lower will result in allocations of memory in the code due to the increments.

dpo commented 2 years ago

I think we should request 0.19.

codecov[bot] commented 2 years ago

Codecov Report

Merging #50 (2f74db5) into main (c06d8a1) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #50   +/-   ##
=======================================
  Coverage   90.38%   90.38%           
=======================================
  Files           5        5           
  Lines         312      312           
=======================================
  Hits          282      282           
  Misses         30       30           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c06d8a1...2f74db5. Read the comment docs.

AntoninKns commented 2 years ago

To summarize, these are the current versions of the dependancies in this commit :

CodecBzip2 = "0.7" DataFrames = "1.2" JLD2 = "0.4" NLPModels = "0.19" julia = "^1.3.1"

CodecBzip2 is still in 0.7.2 DataFrames has had a new release as 1.3.4 JLD2 is still in 0.4.22 NLPModels is up to 0.19 now And for Julia release I guess it is ok to allow from 1.3

I can eventually try to test if it still works with DataFrames 1.3