Closed AntoninKns closed 2 years ago
Merging #53 (119739e) into main (7de12f7) will increase coverage by
1.06%
. The diff coverage is93.33%
.
@@ Coverage Diff @@
## main #53 +/- ##
==========================================
+ Coverage 90.38% 91.44% +1.06%
==========================================
Files 5 5
Lines 312 339 +27
==========================================
+ Hits 282 310 +28
+ Misses 30 29 -1
Impacted Files | Coverage Δ | |
---|---|---|
src/BundleAdjustmentArtifactFunctions.jl | 85.03% <93.10%> (+5.03%) |
:arrow_up: |
src/BundleAdjustmentNLSFunctions.jl | 93.33% <100.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 7de12f7...119739e. Read the comment docs.
Why not remove the old constructor? It doesn't have any advantage, does it?
I kept it only to avoid breaking other existing packages. That being said I think I'm the only one to use it yet so I can remove it.
you can deprecate it just to be careful: https://docs.julialang.org/en/v1/base/base/#Base.@deprecate
As stated in pull request #57, constructors had flaws which created bugs, for example with @deprecate
macro. Therefore I chose to change them and close this pull request.
Adding new constructor requiring only the name of the problem, the group is then found automatically.