JuliaSmoothOptimizers / BundleAdjustmentModels.jl

Julia repository of bundle adjustment problems
Mozilla Public License 2.0
9 stars 5 forks source link

Adding new constructor #53

Closed AntoninKns closed 2 years ago

AntoninKns commented 2 years ago

Adding new constructor requiring only the name of the problem, the group is then found automatically.

codecov[bot] commented 2 years ago

Codecov Report

Merging #53 (119739e) into main (7de12f7) will increase coverage by 1.06%. The diff coverage is 93.33%.

@@            Coverage Diff             @@
##             main      #53      +/-   ##
==========================================
+ Coverage   90.38%   91.44%   +1.06%     
==========================================
  Files           5        5              
  Lines         312      339      +27     
==========================================
+ Hits          282      310      +28     
+ Misses         30       29       -1     
Impacted Files Coverage Δ
src/BundleAdjustmentArtifactFunctions.jl 85.03% <93.10%> (+5.03%) :arrow_up:
src/BundleAdjustmentNLSFunctions.jl 93.33% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7de12f7...119739e. Read the comment docs.

AntoninKns commented 2 years ago

Why not remove the old constructor? It doesn't have any advantage, does it?

I kept it only to avoid breaking other existing packages. That being said I think I'm the only one to use it yet so I can remove it.

dpo commented 2 years ago

you can deprecate it just to be careful: https://docs.julialang.org/en/v1/base/base/#Base.@deprecate

AntoninKns commented 2 years ago

As stated in pull request #57, constructors had flaws which created bugs, for example with @deprecate macro. Therefore I chose to change them and close this pull request.