search

JuliaSmoothOptimizers / BundleAdjustmentModels.jl

Julia repository of bundle adjustment problems
Mozilla Public License 2.0
9 stars 5 forks source link

Update constructors #57

Closed AntoninKns closed 2 years ago

AntoninKns commented 2 years ago

Constructors were poorly designed which caused problems in pull request #53. In order to avoid further problems I decided to redesign the constructors and adapt the rest of the code for this matter. These changes replace pull request #53 which will be closed. It also outdates pull request #42 which will also be closed.

codecov[bot] commented 2 years ago

Codecov Report

Merging #57 (c3a6367) into main (f4cf6a2) will increase coverage by 0.95%. The diff coverage is 95.65%.

@@            Coverage Diff             @@
##             main      #57      +/-   ##
==========================================
+ Coverage   91.24%   92.20%   +0.95%     
==========================================
  Files           5        5              
  Lines         297      295       -2     
==========================================
+ Hits          271      272       +1     
+ Misses         26       23       -3
Impacted Files Coverage Δ
src/BundleAdjustmentArtifactFunctions.jl 82.29% <93.75%> (+2.29%) :arrow_up:
src/BundleAdjustmentNLSFunctions.jl 96.26% <100.00%> (+0.07%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f4cf6a2...c3a6367. Read the comment docs.

dpo commented 2 years ago

Thank you. The tutorial needs similar updates to the README.