search

JuliaSmoothOptimizers / BundleAdjustmentModels.jl

Julia repository of bundle adjustment problems
Mozilla Public License 2.0
9 stars 5 forks source link

Avoid broadcast in residual function #84

Closed tmigot closed 4 months ago

tmigot commented 1 year ago

So that, we can use AD with the residual function

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.17 :tada:

Comparison is base (9585863) 92.54% compared to head (cda0ea5) 92.71%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #84 +/- ## ========================================== + Coverage 92.54% 92.71% +0.17% ========================================== Files 5 5 Lines 295 302 +7 ========================================== + Hits 273 280 +7 Misses 22 22 ``` | [Impacted Files](https://app.codecov.io/gh/JuliaSmoothOptimizers/BundleAdjustmentModels.jl/pull/84?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaSmoothOptimizers) | Coverage Δ | | |---|---|---| | [src/BundleAdjustmentNLSFunctions.jl](https://app.codecov.io/gh/JuliaSmoothOptimizers/BundleAdjustmentModels.jl/pull/84?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaSmoothOptimizers#diff-c3JjL0J1bmRsZUFkanVzdG1lbnROTFNGdW5jdGlvbnMuamw=) | `97.36% <100.00%> (+0.17%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

dpo commented 4 months ago

Really? Can’t AD deal with broadcast???