JuliaSmoothOptimizers / HSL.jl

Julia interface to the HSL Mathematical Software Library
Other
45 stars 16 forks source link

Use HSL_jll.jl in HSL.jl #175

Closed amontoison closed 1 year ago

amontoison commented 1 year ago
codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 0.26% and project coverage change: -74.52 :warning:

Comparison is base (55444ef) 75.05% compared to head (0d3a9bf) 0.53%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #175 +/- ## ========================================== - Coverage 75.05% 0.53% -74.52% ========================================== Files 7 11 +4 Lines 449 1488 +1039 ========================================== - Hits 337 8 -329 - Misses 112 1480 +1368 ``` | [Impacted Files](https://codecov.io/gh/JuliaSmoothOptimizers/HSL.jl/pull/175?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaSmoothOptimizers) | Coverage Δ | | |---|---|---| | [src/Fortran/kb07.jl](https://codecov.io/gh/JuliaSmoothOptimizers/HSL.jl/pull/175?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaSmoothOptimizers#diff-c3JjL0ZvcnRyYW4va2IwNy5qbA==) | `0.00% <0.00%> (ø)` | | | [src/Fortran/mc21.jl](https://codecov.io/gh/JuliaSmoothOptimizers/HSL.jl/pull/175?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaSmoothOptimizers#diff-c3JjL0ZvcnRyYW4vbWMyMS5qbA==) | `0.00% <0.00%> (ø)` | | | [src/Fortran/mc77.jl](https://codecov.io/gh/JuliaSmoothOptimizers/HSL.jl/pull/175?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaSmoothOptimizers#diff-c3JjL0ZvcnRyYW4vbWM3Ny5qbA==) | `0.00% <0.00%> (ø)` | | | [src/hsl\_ma57.jl](https://codecov.io/gh/JuliaSmoothOptimizers/HSL.jl/pull/175?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaSmoothOptimizers#diff-c3JjL2hzbF9tYTU3Lmps) | `0.00% <0.00%> (-81.99%)` | :arrow_down: | | [src/hsl\_ma57\_patch.jl](https://codecov.io/gh/JuliaSmoothOptimizers/HSL.jl/pull/175?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaSmoothOptimizers#diff-c3JjL2hzbF9tYTU3X3BhdGNoLmps) | `0.00% <0.00%> (ø)` | | | [src/hsl\_ma97.jl](https://codecov.io/gh/JuliaSmoothOptimizers/HSL.jl/pull/175?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaSmoothOptimizers#diff-c3JjL2hzbF9tYTk3Lmps) | `0.00% <0.00%> (-78.13%)` | :arrow_down: | | [src/kb07.jl](https://codecov.io/gh/JuliaSmoothOptimizers/HSL.jl/pull/175?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaSmoothOptimizers#diff-c3JjL2tiMDcuamw=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [src/mc21.jl](https://codecov.io/gh/JuliaSmoothOptimizers/HSL.jl/pull/175?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaSmoothOptimizers#diff-c3JjL21jMjEuamw=) | `0.00% <ø> (-93.75%)` | :arrow_down: | | [src/mc77.jl](https://codecov.io/gh/JuliaSmoothOptimizers/HSL.jl/pull/175?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaSmoothOptimizers#diff-c3JjL21jNzcuamw=) | `0.00% <0.00%> (-92.21%)` | :arrow_down: | | [src/C/juliahsl.jl](https://codecov.io/gh/JuliaSmoothOptimizers/HSL.jl/pull/175?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaSmoothOptimizers#diff-c3JjL0MvanVsaWFoc2wuamw=) | `0.21% <0.21%> (ø)` | | | ... and [1 more](https://codecov.io/gh/JuliaSmoothOptimizers/HSL.jl/pull/175?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaSmoothOptimizers) | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

amontoison commented 1 year ago

Looks good to me. Thanks @amontoison Do you have a plan to have libhsl installed for the unit tests?

Yes, we can install the official HSL_jll.jl on our self-hosted builds. I also created a private repository JSO/HSL_jll.jl but I don't know if we are allowed to clone it in the GitHub Actions builds of this repository.