search

JuliaSmoothOptimizers / JSOSolvers.jl

Other
71 stars 15 forks source link

CompatHelper: bump compat for NLPModelsModifiers to 0.7, (keep existing compat) #257

Closed github-actions[bot] closed 8 months ago

github-actions[bot] commented 8 months ago

This pull request changes the compat entry for the NLPModelsModifiers package from 0.6 to 0.6, 0.7. This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry. It is your responsibility to make sure that your package tests pass before you merge this pull request.

farhadrclass commented 8 months ago

this would close this issue https://github.com/JuliaSmoothOptimizers/JSOSolvers.jl/issues/258

github-actions[bot] commented 8 months ago
Package name latest stable
FletcherPenaltySolver.jl
Percival.jl
codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.48%. Comparing base (f52b678) to head (56eb82b).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #257 +/- ## ======================================= Coverage 88.48% 88.48% ======================================= Files 7 7 Lines 1025 1025 ======================================= Hits 907 907 Misses 118 118 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

dpo commented 8 months ago

The tests were failing with those versions. I assumed it was because of a mismatch between LO and NLPMM.